fix(macos): notarization (sign nested code; fail+log on reject)#59
Merged
Conversation
…n reject) The 2.1.0-rc1 release build signed and submitted the .app but Apple returned "status: Invalid", and the script then tried to staple a rejected artifact (exit 65). Two fixes: - Sign every nested Mach-O (dylib/.so) explicitly with the hardened runtime + timestamp before sealing the bundle. `codesign --deep` is unreliable for notarization, which rejects bundles containing any unsigned/old-signature nested code (the usual cause of "Invalid" for PyInstaller apps). - notarize_and_staple now checks for "status: Accepted"; on anything else it prints Apple's detailed notary log (xcrun notarytool log <id>) and fails the build instead of stapling a rejected artifact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.1.0-rc1 release surfaced that macOS notarization returns status: Invalid and the script then failed stapling a rejected build (exit 65).
.dylib/.so) explicitly (hardened runtime + timestamp) before sealing the bundle —codesign --deepis unreliable for notarization, the usual cause of "Invalid" on PyInstaller apps.notarize_and_staplenow verifiesstatus: Accepted; otherwise it prints Apple's detailed notary log and fails the build instead of stapling a rejected artifact.Validates on the next release tag. (rc1's run was cancelled since macOS failed and it couldn't publish.)
🤖 Generated with Claude Code