build(macos): sign + notarize builds (local opt-in and in CI)#54
Merged
Conversation
Make signed, notarized macOS builds first-class instead of a printed TODO: - build_macos.sh: when MACOS_SIGN_IDENTITY is set, deep-sign the .app (hardened runtime + entitlements) before building the .dmg, then sign the .dmg and, when notary credentials are present (keychain profile or Apple-ID), notarize + staple it. Unset → unsigned build with the manual steps printed as before. - release.yml: the macOS job imports a Developer ID cert from repo secrets into a temporary keychain and passes the signing/notary env through; absent secrets fall back to an unsigned .dmg so forks still build. - docs/building.md: document the opt-in local env vars and the required CI secrets (MACOS_CERTIFICATE_P12_BASE64/PASSWORD, MACOS_SIGN_IDENTITY, MACOS_NOTARY_APPLE_ID/TEAM_ID/PASSWORD). installation.md: signed releases open normally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes signed, notarized macOS builds first-class (previously the script only printed manual steps).
What
MACOS_SIGN_IDENTITY— deep-signs the.app(hardened runtime +entitlements.plist), signs the.dmg, and notarizes + staples when notary creds are present. Unset → unsigned build, manual steps printed as before..dmg(forks still build).Action needed: add these repo secrets (Settings → Secrets and variables → Actions)
MACOS_CERTIFICATE_P12_BASE64.p12, base64'dMACOS_CERTIFICATE_PASSWORD.p12export passwordMACOS_SIGN_IDENTITYDeveloper ID Application: Your Name (TEAMID)MACOS_NOTARY_APPLE_IDMACOS_NOTARY_TEAM_IDMACOS_NOTARY_PASSWORDI can't test real signing without the cert; the script's unsigned path and the YAML are validated.
🤖 Generated with Claude Code