Collision data shape ordering (second attempt) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MondayHopscotch
commented
Jan 16, 2024
echo/util/SAT.hx
Outdated
| @@ -495,7 +506,7 @@ class SAT { | |||
| test1 = min1 - max2; | |||
| test2 = min2 - max1; | |||
|
|
|||
| // Preform another test | |||
| // Preform another test // TODO: What is this test doing, exactly? | |||
There was a problem hiding this comment.
I couldn't articulate exactly what this test is doing, so a short descriptor might help future folks if they need to come in here for any reason.
MondayHopscotch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a good bit of cruft in it still. I just wanted to put up the code along with the extra test states that I used to debug the issue to give you a chance to see what I did. If this looks good, I will prune down the code and put up a clean PR without all the extra junk.See #41. This PR attempts to correct the order that data is passed to collision listeners such that the shapes are in the proper order.