-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change player type #1
base: master
Are you sure you want to change the base?
Conversation
Лучше разделять каждую фичу отдельным реквестом. В данном случае добавление нового типа персонажа и типа оружия - немного разное. |
src/main/java/aunmag/shooter/game/client/states/ScenarioStatus.java
Outdated
Show resolved
Hide resolved
Changed the mechanism of player choice
Various small innovations
# Conflicts: # src/main/java/aunmag/shooter/game/ai/Ai.java # src/main/java/aunmag/shooter/game/client/Player.kt # src/main/java/aunmag/shooter/game/client/player/Blackout.java # src/main/java/aunmag/shooter/game/client/states/Game.kt # src/main/java/aunmag/shooter/game/client/states/Pause.kt # src/main/java/aunmag/shooter/game/environment/actor/ActorType.java !Actor change does not work!
@@ -25,6 +25,8 @@ public void reset() { | |||
turningTo = null; | |||
} | |||
|
|||
/* Setters */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну там же сеттеры по сути. Я и перенес этот комментарий, чтобы он был над ними. Раньше был под ними.
Метод reset
не включил под этот комментарий, потому что это общий метод сброса состояния. Неизвестно, что туда ещё добавится. А те методы, над которыми я этот комментарий перенес типичные сеттеры - конкретное поле устанавливается в конкретное значение
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
walkForward
не принимает ведь аргументов, это не сеттер.
src/main/java/aunmag/shooter/game/environment/actor/ActorType.java
Outdated
Show resolved
Hide resolved
src/main/java/aunmag/shooter/game/environment/actor/ActorType.java
Outdated
Show resolved
Hide resolved
10 -> WeaponType.saiga12k | ||
11 -> WeaponType.pkm | ||
12 -> WeaponType.pkpPecheneg | ||
3 -> WeaponType.coltSingleActionArmy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Изначально планировалось что бы не первой волне были только пистолеты, на второй двуствольные ружья, далее ПП, и так далее
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сейчас все твои оружия могут выпасть только на тех же волнах как раньше. Плюс, к тем, которые могут выпасть на первой волне, добавляется револьвер.
@@ -7,3 +7,4 @@ shooter.iml | |||
src/main/resources/**/*.png | |||
src/main/resources/**/*.ogg | |||
src/main/resources/**/*.fnt | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лишнее
nbactions.xml
Outdated
@@ -0,0 +1,49 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лишнее
Colt power reduced
aeb12b9
to
f17b38a
Compare
# Conflicts: # src/main/java/aunmag/shooter/game/ai/strategies/Strategy.java # src/main/java/aunmag/shooter/game/client/states/Pause.kt # src/main/java/aunmag/shooter/game/environment/actor/Actor.java # src/main/java/aunmag/shooter/game/scenarios/ScenarioEncircling.kt
# Conflicts: # src/main/java/aunmag/shooter/game/ai/strategies/Strategy.java # src/main/java/aunmag/shooter/game/client/states/Pause.kt # src/main/java/aunmag/shooter/game/environment/actor/Actor.java # src/main/java/aunmag/shooter/game/scenarios/ScenarioEncircling.kt
Player choice implemented in non Kotlin version
No description provided.