Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to change player type #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

FedotSoldier
Copy link
Collaborator

@FedotSoldier FedotSoldier commented Apr 7, 2019

No description provided.

nb-configuration.xml Outdated Show resolved Hide resolved
src/main/java/aunmag/shooter/game/client/Player.kt Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Aunmag
Copy link
Owner

Aunmag commented Apr 11, 2019

Лучше разделять каждую фичу отдельным реквестом. В данном случае добавление нового типа персонажа и типа оружия - немного разное.

Changed the mechanism of player choice
Various small innovations
# Conflicts:
#	src/main/java/aunmag/shooter/game/ai/Ai.java
#	src/main/java/aunmag/shooter/game/client/Player.kt
#	src/main/java/aunmag/shooter/game/client/player/Blackout.java
#	src/main/java/aunmag/shooter/game/client/states/Game.kt
#	src/main/java/aunmag/shooter/game/client/states/Pause.kt
#	src/main/java/aunmag/shooter/game/environment/actor/ActorType.java

!Actor change does not work!
@@ -25,6 +25,8 @@ public void reset() {
turningTo = null;
}

/* Setters */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем?

Copy link
Collaborator Author

@FedotSoldier FedotSoldier Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну там же сеттеры по сути. Я и перенес этот комментарий, чтобы он был над ними. Раньше был под ними.
Метод reset не включил под этот комментарий, потому что это общий метод сброса состояния. Неизвестно, что туда ещё добавится. А те методы, над которыми я этот комментарий перенес типичные сеттеры - конкретное поле устанавливается в конкретное значение

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walkForward не принимает ведь аргументов, это не сеттер.

src/main/java/aunmag/shooter/game/client/states/Pause.kt Outdated Show resolved Hide resolved
10 -> WeaponType.saiga12k
11 -> WeaponType.pkm
12 -> WeaponType.pkpPecheneg
3 -> WeaponType.coltSingleActionArmy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Изначально планировалось что бы не первой волне были только пистолеты, на второй двуствольные ружья, далее ПП, и так далее

Copy link
Collaborator Author

@FedotSoldier FedotSoldier Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сейчас все твои оружия могут выпасть только на тех же волнах как раньше. Плюс, к тем, которые могут выпасть на первой волне, добавляется револьвер.

@@ -7,3 +7,4 @@ shooter.iml
src/main/resources/**/*.png
src/main/resources/**/*.ogg
src/main/resources/**/*.fnt

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишнее

nbactions.xml Outdated
@@ -0,0 +1,49 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишнее

@Aunmag Aunmag force-pushed the master branch 2 times, most recently from aeb12b9 to f17b38a Compare July 6, 2019 13:08
# Conflicts:
#	src/main/java/aunmag/shooter/game/ai/strategies/Strategy.java
#	src/main/java/aunmag/shooter/game/client/states/Pause.kt
#	src/main/java/aunmag/shooter/game/environment/actor/Actor.java
#	src/main/java/aunmag/shooter/game/scenarios/ScenarioEncircling.kt
# Conflicts:
#	src/main/java/aunmag/shooter/game/ai/strategies/Strategy.java
#	src/main/java/aunmag/shooter/game/client/states/Pause.kt
#	src/main/java/aunmag/shooter/game/environment/actor/Actor.java
#	src/main/java/aunmag/shooter/game/scenarios/ScenarioEncircling.kt
Player choice implemented in non Kotlin version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants