Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inserting single PG enum #100

Merged
merged 4 commits into from
Feb 2, 2025
Merged

fix inserting single PG enum #100

merged 4 commits into from
Feb 2, 2025

Conversation

AugustNagro
Copy link
Owner

closes #94

KaranAhlawat
KaranAhlawat suggested changes Jan 23, 2025
View reviewed changes
Copy link

@KaranAhlawat KaranAhlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks right, although I'm not the most well-versed in metaprogramming, but the implementation made sense to me.

magnum-pg/src/main/scala/com/augustnagro/magnum/pg/enums/PgEnumDbCodec.scala Outdated
import quotes.reflect.*
val mirror = Expr.summon[Mirror.SumOf[A]].getOrElse {
report.errorAndAbort(
"Can only derive SqlArrayCodec for simple (non ADT) Enums"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SqlArrayCodec should be EnumDbCodec, or a variant of it, no?

@KaranAhlawat KaranAhlawat mentioned this pull request Jan 23, 2025
Open
@AugustNagro AugustNagro merged commit ad611ce into master Feb 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaranAhlawat KaranAhlawat KaranAhlawat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting a PG enum
2 participants
@AugustNagro @KaranAhlawat