Added functionality to automatically URL encode the room name if required#15
Open
Added functionality to automatically URL encode the room name if required#15
Conversation
Collaborator
Author
|
I know the issue raised for this is really old, but I'm clearing down old issues in my name and it seemed like an easy one to implement in case it is of use to anyone. Note I don't personally still use Hipchat so i'm not able to perform any real world testing unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #4 to automatically handle room name encoding for the -room parameter.
Description
Uses the [system.web.httputility] class to perform a URLdecode (in case the user has already done URL encoding) and then re-encode it. Has a try catch around it so if the class is not available it will continue to work without having modified $room, but prints a warning. I'm not sure how backwards compatible [system.web.httputility] is, but its available on PS7 under MacOS.
Motivation and Context
Closes #4
Types of changes
Checklist: