Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Backup Related State #152

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Sep 16, 2024

Description

Refactor Backup Related State

Related issue: #113 (comment)

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge

@mlajkim mlajkim added the refactor Changes without functional changes, or api changes) label Sep 16, 2024
@mlajkim mlajkim self-assigned this Sep 16, 2024
Copy link
Contributor

@y-myajima y-myajima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y-myajima y-myajima merged commit f577400 into main Sep 16, 2024
8 checks passed
@y-myajima y-myajima deleted the refactor/secret-backup-derived branch September 16, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes without functional changes, or api changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants