Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Refactor: k8s derived state Prototype #151

Closed
wants to merge 16 commits into from

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Sep 15, 2024

Description

Refactor k8s derived state.

Related task: #113 (comment)

Once refactored, it is off the derived state so decided not to implement it

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge

@mlajkim mlajkim added the refactor Changes without functional changes, or api changes) label Sep 15, 2024
@mlajkim mlajkim self-assigned this Sep 15, 2024
@mlajkim mlajkim changed the title Refactor: k8s derived state [DNM] Refactor: k8s derived state Prototype Sep 15, 2024
@mlajkim mlajkim marked this pull request as draft September 15, 2024 06:17
@mlajkim
Copy link
Contributor Author

mlajkim commented Sep 16, 2024

Closed as we've learned that something else other than derived-state is needed for states like:

  • Kubernetes like:
	K8s            DerivedK8s
	namespace      string
	serviceAccount string
	podIP          net.IP
	podUID         string
	podName        string
	certSecret     string
  • X509 related envs like :
	CaCertFile             string
	IntermediateCertBundle string
        DNSSuffix string

@mlajkim mlajkim closed this Sep 16, 2024
@mlajkim mlajkim deleted the refactor/kubernetes-config branch September 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes without functional changes, or api changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant