Skip to content

Commit

Permalink
UI: Fix tab order (settings before history) (#1535)
Browse files Browse the repository at this point in the history
Signed-off-by: Ofer Levi <[email protected]>
  • Loading branch information
OferLevi85 authored Jul 7, 2021
1 parent bc610ed commit ddfa942
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,17 +134,17 @@ exports[`Tabs should render 1`] = `
>
Templates
</div>
<div
class="emotion-1 denali-tab active"
data-active="true"
>
History
</div>
<div
class="emotion-1 denali-tab"
data-active="false"
>
Settings
</div>
<div
class="emotion-1 denali-tab active"
data-active="true"
>
History
</div>
</div>
`;
Original file line number Diff line number Diff line change
Expand Up @@ -1358,18 +1358,18 @@ exports[`DomainSettingsPage should render 1`] = `
>
Templates
</div>
<div
class="emotion-74 denali-tab"
data-active="false"
>
History
</div>
<div
class="emotion-74 denali-tab active"
data-active="true"
>
Settings
</div>
<div
class="emotion-74 denali-tab"
data-active="false"
>
History
</div>
</div>
</div>
<div
Expand Down
4 changes: 2 additions & 2 deletions ui/src/__tests__/pages/__snapshots__/policy.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1271,13 +1271,13 @@ exports[`PolicyPage should render 1`] = `
class="emotion-77 denali-tab"
data-active="false"
>
History
Settings
</div>
<div
class="emotion-77 denali-tab"
data-active="false"
>
Settings
History
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/__tests__/pages/__snapshots__/role.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1479,13 +1479,13 @@ exports[`RolePage should render 1`] = `
class="emotion-74 denali-tab"
data-active="false"
>
History
Settings
</div>
<div
class="emotion-74 denali-tab"
data-active="false"
>
Settings
History
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/__tests__/pages/__snapshots__/service.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1307,13 +1307,13 @@ exports[`ServicePage should render 1`] = `
class="emotion-77 denali-tab"
data-active="false"
>
History
Settings
</div>
<div
class="emotion-77 denali-tab"
data-active="false"
>
Settings
History
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/__tests__/pages/__snapshots__/tags.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1237,13 +1237,13 @@ exports[`Tag Page should render 1`] = `
class="emotion-77 denali-tab"
data-active="false"
>
History
Settings
</div>
<div
class="emotion-77 denali-tab"
data-active="false"
>
Settings
History
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/__tests__/pages/__snapshots__/template.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1257,13 +1257,13 @@ exports[`Template Page should render 1`] = `
class="emotion-77 denali-tab"
data-active="false"
>
History
Settings
</div>
<div
class="emotion-77 denali-tab"
data-active="false"
>
Settings
History
</div>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions ui/src/components/header/Tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ class Tabs extends React.Component {
label: 'Templates',
name: 'templates',
},
{
label: 'History',
name: 'history',
},
{
label: 'Settings',
name: 'domain-settings',
},
{
label: 'History',
name: 'history',
},
];

tabClicked(tab) {
Expand Down

0 comments on commit ddfa942

Please sign in to comment.