use checked exceptions in server modules

Signed-off-by: Abhijeet V <[email protected]>
AthenZ · Jan 10, 2025 · 791f6ac · 791f6ac
1 parent dd2eff4
commit 791f6ac
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/...main/java/com/yahoo/athenz/common/server/msd/repository/StaticWorkloadDataRepository.java b/...main/java/com/yahoo/athenz/common/server/msd/repository/StaticWorkloadDataRepository.java
@@ -18,6 +18,7 @@
 package com.yahoo.athenz.common.server.msd.repository;
 
 import com.yahoo.athenz.auth.PrivateKeyStore;
+import com.yahoo.athenz.common.server.ServerResourceException;
 import com.yahoo.athenz.common.server.dns.HostnameResolver;
 import com.yahoo.athenz.common.server.msd.MsdStore;
 
@@ -41,5 +42,5 @@ public interface StaticWorkloadDataRepository<T> {
      * @param key map key to retrieve a specific Value Object from the repository
      * @return a generic Value Object used by various repository implementations
      */
-    T getDataByKey(String key);
+    T getDataByKey(String key) throws ServerResourceException;
 }
diff --git a/.../src/main/java/com/yahoo/athenz/common/server/msd/validator/TransportPolicyValidator.java b/.../src/main/java/com/yahoo/athenz/common/server/msd/validator/TransportPolicyValidator.java
@@ -15,6 +15,7 @@
  */
 package com.yahoo.athenz.common.server.msd.validator;
 
+import com.yahoo.athenz.common.server.ServerResourceException;
 import com.yahoo.athenz.common.server.msd.MsdStore;
 import com.yahoo.athenz.msd.TransportPolicyValidationRequest;
 import com.yahoo.athenz.msd.TransportPolicyValidationResponse;
@@ -28,5 +29,5 @@ default void init(MsdStore store) {
      * validateTransportPolicy validates the transport policy against other pre-defined policies
      * @param transportPolicy transport policy to be validated
      */
-    TransportPolicyValidationResponse validateTransportPolicy(TransportPolicyValidationRequest transportPolicy);
+    TransportPolicyValidationResponse validateTransportPolicy(TransportPolicyValidationRequest transportPolicy) throws ServerResourceException;
 }
diff --git a/...t/java/com/yahoo/athenz/common/server/msd/validator/NoOpTransportPolicyValidatorTest.java b/...t/java/com/yahoo/athenz/common/server/msd/validator/NoOpTransportPolicyValidatorTest.java
@@ -17,11 +17,12 @@
 
 package com.yahoo.athenz.common.server.msd.validator;
 
+import com.yahoo.athenz.common.server.ServerResourceException;
 import com.yahoo.athenz.msd.TransportPolicyValidationRequest;
 import com.yahoo.athenz.msd.TransportPolicyValidationStatus;
 import org.testng.annotations.Test;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertTrue;
+
+import static org.testng.Assert.*;
 
 public class NoOpTransportPolicyValidatorTest {
 
@@ -32,6 +33,11 @@ public void testNoOpValidator() {
         TransportPolicyValidator validator = factory.create();
         assertTrue(validator instanceof NoOpTransportPolicyValidator);
         TransportPolicyValidationRequest request = new TransportPolicyValidationRequest();
-        assertEquals(validator.validateTransportPolicy(request).getStatus(), TransportPolicyValidationStatus.VALID);
+        TransportPolicyValidationStatus status = null;
+        try {
+            assertEquals(validator.validateTransportPolicy(request).getStatus(), TransportPolicyValidationStatus.VALID);
+        } catch (ServerResourceException e) {
+            fail();
+        }
     }
 }