Skip to content

Add cargo-binstall support#105

Merged
rs545837 merged 1 commit into
mainfrom
add-binstall-support
Jun 7, 2026
Merged

Add cargo-binstall support#105
rs545837 merged 1 commit into
mainfrom
add-binstall-support

Conversation

@rs545837

@rs545837 rs545837 commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Add [package.metadata.binstall] to weave-cli, weave-driver, and weave-mcp
  • Maps to existing release asset naming ({name}-{target}.tar.gz, .zip for Windows)
  • Enables cargo binstall weave-cli, cargo binstall weave-driver, cargo binstall weave-mcp

Closes #104

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 9 entities analyzed | 0 critical, 0 high, 0 medium, 9 low
Verdict: standard_review

Findings (4)

  1. [low] In all three Cargo.toml files, the binstall configuration uses bin-dir = "{ bin }{ binary-ext }" which is incorrect. The bin-dir field should specify the directory path within the archive where binaries are located, not the binary filename itself. This will cause cargo-binstall to look for binaries in the wrong location within the downloaded archive.
  2. [low] In crates/weave-cli/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.
  3. [low] In crates/weave-driver/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.
  4. [low] In crates/weave-mcp/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.

Reviewed by inspect | Entity-level triage found 0 high-risk changes

@rs545837 rs545837 merged commit e45c6df into main Jun 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cargo binstall support

1 participant