Add cargo-binstall support#105
Merged
Merged
Conversation
There was a problem hiding this comment.
inspect review
Triage: 9 entities analyzed | 0 critical, 0 high, 0 medium, 9 low
Verdict: standard_review
Findings (4)
- [low] In all three Cargo.toml files, the binstall configuration uses
bin-dir = "{ bin }{ binary-ext }"which is incorrect. Thebin-dirfield should specify the directory path within the archive where binaries are located, not the binary filename itself. This will cause cargo-binstall to look for binaries in the wrong location within the downloaded archive. - [low] In crates/weave-cli/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.
- [low] In crates/weave-driver/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.
- [low] In crates/weave-mcp/Cargo.toml, bin-dir template uses '{ bin }{ binary-ext }' which appears incorrect. The bin-dir should specify the directory path within the archive where binaries are located, not the binary name itself. This should likely be just '{ bin }' or an empty string if binaries are at the root of the archive.
Reviewed by inspect | Entity-level triage found 0 high-risk changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[package.metadata.binstall]to weave-cli, weave-driver, and weave-mcp{name}-{target}.tar.gz,.zipfor Windows)cargo binstall weave-cli,cargo binstall weave-driver,cargo binstall weave-mcpCloses #104