Distinguish JavaScript and TypeScript accessors#289
Closed
Iron-Ham wants to merge 1 commit into
Closed
Conversation
![inspect-review[bot]](https://avatars.githubusercontent.com/in/3177512?s=60&v=4){kind=small}
There was a problem hiding this comment.
inspect review
Triage: 18 entities analyzed | 0 critical, 0 high, 5 medium, 13 low
Verdict: standard_review
Findings (2)
- [low] In
map_js_ts_accessor_method_type, the function returnsNonefor non-JS/TS languages, but the caller inmap_entity_typeusesunwrap_or_else(|| map_node_type(node.kind()))which will callmap_node_typefor all non-accessor method_definitions in JS/TS. This means regular methods in JS/TS will be mapped twice - once through the None path and once through the fallback, potentially causing incorrect entity types. - [low] In
split_type_qualified_query, the function splits on the first space and checks if both parts are non-empty, but it doesn't validate thatentity_typeis a valid entity type. This means queries like 'invalid_type value' will pass validation and match entities with entity_type='invalid_type', which may not exist, leading to confusing behavior where queries appear valid but never match.
Reviewed by inspect | Entity-level triage found 0 high-risk changes
Contributor
Author
|
Superseded by #309. |
rs545837
pushed a commit
that referenced
this pull request
Jun 5, 2026
## Summary - consolidate the open TypeScript/JavaScript parser, extraction, accessor, namespace, abstract entity, and import-resolution fixes - keep the combined graph/scope behavior from the parent PRs in one reviewable branch Supersedes #303, #305, #291, #289, #288, #285. Fixes #264. Fixes #262. Fixes #265. Closes #267. Fixes #266. Fixes #263. ## Test plan - cargo test --manifest-path crates/Cargo.toml -p sem-core typescript - cargo test --manifest-path crates/Cargo.toml -p sem-core js_ts - cargo test --manifest-path crates/Cargo.toml -p sem-core import_resolution - cargo test --manifest-path crates/Cargo.toml -p sem-core scope_resolve_typescript - cargo test --manifest-path crates/Cargo.toml -p sem-cli --test accessor_cli - cargo check --manifest-path crates/Cargo.toml -p sem-core -p sem-cli - cargo test --manifest-path crates/Cargo.toml -p sem-core graph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Summary
getter valueandsetter valueTest plan
cargo test -p sem-core --no-fail-fastcargo test -p sem-cli --no-fail-fasttarget/debug/semin temporary git repos forentities,diff,context, andimpactaccessor behaviorReview
claude -preview was launched twice, but the CLI produced no output and timed out on the bounded retry