feat(pack): add prettier pack #1502
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
It would be better to do this in a separate PR
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Have you tested it, per the comment you wrote in the PR desc? @azdanov |
| "yaml", | ||
| } | ||
|
|
||
| local lsp_rooter_cache, prettierrc_rooter_cache |
There was a problem hiding this comment.
Good question. I extracted what was there already in the typescript pack without changing much.
| return true | ||
| end | ||
|
|
||
| local conform_formatter = function(bufnr) return has_prettier(bufnr) and { "prettierd" } or {} end |
| local null_ls_formatter = function(params) | ||
| if vim.tbl_contains(format_filetypes, params.filetype) then return has_prettier(params.bufnr) end | ||
| return true | ||
| end |
I'll test run it again next week at work to make sure nothing breaks during daily usage. I did test it when creating the PR, but maybe things changed or I missed something, since I don't use null-ls at all. |
Issue #1501
📑 Description
Extracted prettier into separate pack. I'm wondering if I should add support for other languages like html, css, yaml, json etc. Maybe via
vim.g.prettier.format_filetypes?Still need to test it with null_ls and conform to see that it performs similar as before.
ℹ Additional Information