refactor(app): extract settings general section owners

[Astro-Han]

Summary

Extracts owner components from the oversized General settings surface:

• SettingsRow shared settings row wrapper
• SettingsWebSearchRow for Web Search status/manage/toggle controls
• SettingsNotificationsSection for notification toggles
• SettingsSoundsSection for sound selects and preview playback ownership
• SettingsUpdatesSection for update toggles/check flow

settings-general.tsx drops from 733 LOC on dev to 367 LOC in this PR.

Why

This is a #604 settings-lane frontend governance slice. The goal is to make the General settings surface agent-readable without changing behavior or mixing in unrelated settings work.

Related Issue

Part of #604.

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

• Confirm this is a pure settings owner extraction with no behavior changes.
• Confirm settings-general.tsx now delegates section ownership cleanly.
• Confirm source-contract tests now follow the new owner files instead of weakening coverage.

Topology

• Base: dev
• Head: codex/settings-websearch-row-owner
• Dependency status: independent flat PR. It does not depend on chore: add frontend architecture governance baseline #667, chore(ui): add shared tool contract export #669, refactor(app): extract timeline staging helper #670-refactor(app): remove orphaned timeline header code #675, refactor(ui): extract session turn changes panel #676-refactor(ui): extract session turn diffs #677, fix(ui): harden theme typography follow-ups #673, or refactor(app): extract session share command owner #678.
• Review order: can be reviewed after or alongside the existing flat PRs; it does not touch files modified by the current flat PR set.

Touched Files

• packages/app/src/components/settings-general.tsx
• packages/app/src/components/settings-row.tsx
• packages/app/src/components/settings-web-search-row.tsx
• packages/app/src/components/settings-notifications-section.tsx
• packages/app/src/components/settings-sounds-section.tsx
• packages/app/src/components/settings-updates-section.tsx
• packages/app/src/pages/session/settings-websearch-source.test.ts
• packages/app/src/pages/update-install-flow-source.test.ts

Risk Notes

Behavior should be unchanged. Risk is import wiring or source-contract drift after moving row/section owners. No dependency, migration, data, credential, or platform behavior changes are intended.

How To Verify

Focused app tests: 24 passed
Command: bun test --preload ./happydom.ts src/pages/session/settings-websearch-source.test.ts src/components/dialog-connect-websearch-source.test.ts src/pages/update-install-flow-source.test.ts src/shell-frame-contract.test.ts

Typecheck: 8 successful, 8 total
Command: bun run typecheck

Diff check: no whitespace errors
Command: git diff --check && git diff --cached --check

File-size check: settings-general.tsx 733 LOC on dev -> 367 LOC in this PR
Command: wc -l packages/app/src/components/settings-general.tsx packages/app/src/components/settings-notifications-section.tsx packages/app/src/components/settings-sounds-section.tsx packages/app/src/components/settings-updates-section.tsx packages/app/src/components/settings-web-search-row.tsx packages/app/src/components/settings-row.tsx

Screenshots or Recordings

Not captured. This PR is a structure-only extraction with no intended visual change; the visible row/action contracts are covered by focused source tests and typecheck.

Checklist

• Human review status is stated above as pending, approved, or not required
• I linked the related issue, or stated why there is no issue
• This PR has type, primary area, and priority labels, or I requested maintainer labeling
• I described the review focus and any meaningful risks
• I listed the relevant verification steps and the key result for each
• I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope
• I manually checked visible UI or copy changes when needed, with screenshots or recordings
• I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes
• I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant
• I reviewed the final diff for unrelated changes and suspicious dependency changes
• I am targeting dev, and my PR title and commit messages use Conventional Commits in English

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 42 minutes and 11 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3434b9de-5c4d-4705-96d6-7e1ced59b33d

📥 Commits

Reviewing files that changed from the base of the PR and between 03140f7 and 1827537.

📒 Files selected for processing (8)

• packages/app/src/components/settings-general.tsx
• packages/app/src/components/settings-notifications-section.tsx
• packages/app/src/components/settings-row.tsx
• packages/app/src/components/settings-sounds-section.tsx
• packages/app/src/components/settings-updates-section.tsx
• packages/app/src/components/settings-web-search-row.tsx
• packages/app/src/pages/session/settings-websearch-source.test.ts
• packages/app/src/pages/update-install-flow-source.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/settings-websearch-row-owner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Suggested priority: P2 (includes user-path files (packages/app/src/components/settings-general.tsx, packages/app/src/components/settings-notifications-section.tsx, packages/app/src/components/settings-row.tsx, packages/app/src/components/settings-sounds-section.tsx, packages/app/src/components/settings-updates-section.tsx, packages/app/src/components/settings-web-search-row.tsx, packages/app/src/pages/session/settings-websearch-source.test.ts, packages/app/src/pages/update-install-flow-source.test.ts)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

[github-actions]

Perf delta summary

Comparator: pass

Profile / Scenario	interaction median	interaction worst	long task max	tbt	frame gap p95	frame gap max	jank count	cls	status
default / homepage-cold	32 -> 32 (0)	64 -> 40 (-24)	74 -> 71 (-3)	24 -> 21 (-3)	16.8 -> 33.4 (+16.6)	166.6 -> 133.4 (-33.2)	3 -> 3 (0)	0 -> 0 (0)	pass
default / long-session-input-lag	48 -> 48 (0)	64 -> 48 (-16)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.7 (0)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-streaming-long	40 -> 48 (+8)	64 -> 56 (-8)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.7 (-0.1)	33.3 -> 16.8 (-16.5)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-call-expand	24 -> 16 (-8)	24 -> 24 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.8 (+0.1)	16.7 -> 16.8 (+0.1)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-default-open-heavy-bash	32 -> 24 (-8)	32 -> 24 (-8)	66 -> 66 (0)	16 -> 16 (0)	50 -> 49.9 (-0.1)	116.7 -> 116.7 (0)	3 -> 2 (-1)	0 -> 0 (0)	pass
default / terminal-side-panel-open	56 -> 48 (-8)	64 -> 48 (-16)	0 -> 0 (0)	0 -> 0 (0)	33.4 -> 33.3 (-0.1)	33.4 -> 33.4 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-scroll-reading	24 -> 24 (0)	32 -> 24 (-8)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.7 (0)	16.7 -> 16.7 (0)	0 -> 0 (0)	0.505 -> 0.505 (0)	warn: cls
low-end / session-scroll-reading-long	56 -> 56 (0)	64 -> 56 (-8)	70 -> 69 (-1)	51 -> 43 (-8)	16.8 -> 16.8 (0)	183.3 -> 183.2 (-0.1)	4 -> 4 (0)	0.016 -> 0.016 (0)	pass
low-end / session-timeline-recompute	112 -> 128 (+16)	120 -> 128 (+8)	101 -> 107 (+6)	155 -> 164 (+9)	100 -> 100.1 (+0.1)	166.7 -> 183.3 (+16.6)	4 -> 3 (-1)	0.081 -> 0.081 (0)	pass
low-end / concurrent-shimmer-extreme	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.7 (0)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass