🐛 Fix scratchpad margin config having no effect (fix #12)#13
Open
matclab wants to merge 1 commit intoAsthestarsfalll:mainfrom
Open
🐛 Fix scratchpad margin config having no effect (fix #12)#13matclab wants to merge 1 commit intoAsthestarsfalll:mainfrom
matclab wants to merge 1 commit intoAsthestarsfalll:mainfrom
Conversation
Resize floating window before reading its position so the relative move offset accounts for any position adjustment niri makes during resize. Previously the position was read before resize, causing the computed offset to be stale and the configured margin to be ignored.
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resize floating window before reading its position so the relative
move offset accounts for any position adjustment niri makes during
resize. Previously the position was read before resize, causing the
computed offset to be stale and the configured margin to be ignored.
fix #12