feat: add stack contract compliance sections#35
Conversation
Document GoTrue security policy, UI section state requirements, progress event schema, and error forwarding compliance per exe-os stack-contracts.json. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5f87b4ada
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| All 5xx backend errors are forwarded to exe-monitor-hub via `ErrorForwardingFilter` and `ErrorForwardingService`. | ||
| Configured by `MONITOR_ERROR_URL` and `ERROR_REPORTING_ENABLED` (default: `true`). |
There was a problem hiding this comment.
This states that 5xx backend errors are forwarded and that reporting is enabled by default, but ErrorForwardingService.forwardError returns without sending anything whenever MONITOR_ERROR_URL is unset. A deployment following this contract can leave the URL out and silently get no exe-monitor-hub reports while believing the default enables forwarding; please qualify this as "when MONITOR_ERROR_URL is configured" or mark that variable required for forwarding.
Useful? React with 👍 / 👎.
Without await, NestJS never runs onModuleDestroy hooks — the open Redis connection keeps the event loop alive and the container hangs forever before reaching the main server process. Added 10s safety timeout with unref() as a backstop if close itself stalls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Summary
CONTRACTS.mdwith GoTrue policy, UI section states, progress events, error forwarding docsTest plan
🤖 Generated with Claude Code