Implement Multi-threaded Merge Sort in Java and Rust #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirefoxSRV
requested changes
Jan 1, 2025
| if (arr.length > 1) { | ||
| int mid = arr.length / 2; | ||
|
|
||
| int[] left = new int[mid]; |
There was a problem hiding this comment.
Hi, this could fail if there is a null array (NOT EMPTY). [ NullPointerException is bound to occur] .......
There was a problem hiding this comment.
For very large arrays, int mid = arr.length / 2; could lead to integer overflow if arr.length exceeds Integer.MAX_VALUE (unlikely but theoretically possible).
There was a problem hiding this comment.
Added a check for null arrays
|
|
||
| // Threshold to switch to normal merge sort | ||
| // change this value according to the size of the array to get the best performance | ||
| private static final int THRESHOLD = 5; |
There was a problem hiding this comment.
Isn't the THRESHOLD = 5 seem to look too low ? For performance measurement with small arrays, creating threads is more expensive than sorting them sequentially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Implement Multi-threaded Merge Sort in Java and Rust
This PR adds the implementation of Multi-threaded Merge Sort in both Java and Rust, as stated in issue #42.
Added Features
Changes Made
.gitignoreto excludetargetanddebugfolders from CargoREADME.mdto add instructions for Rust code execution using Cargo