Add CLI flag --gpu=drm|venus|software to support various GPU virtualization modes #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valpackett
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
teohhanhui
reviewed
Sep 26, 2025
teohhanhui
reviewed
Sep 26, 2025
crates/muvm/src/bin/muvm.rs
Outdated
|
|
||
| let virgl_flags = VIRGLRENDERER_USE_EGL | ||
| | VIRGLRENDERER_DRM | ||
| | VIRGLRENDERER_NO_VIRGL |
There was a problem hiding this comment.
Is this flag supposed to be set unconditionally?
There was a problem hiding this comment.
Yeah, after submitting I realized I should've added a comment there – it's seems to only be strictly necessary when not having any dri nodes present (software-only with no GPU devices present, without this flag → guest hang)..
However, legacy virGL is not very desirable (especially in terms of security) and doesn't actually work anyway. So I think it's better to hard-disable it unconditionally.
Yes, please export that variable when Venus is selected. |
…zation modes vDRM is great, but not supported everywhere yet, so on some machines the only way to get GPU acceleration is via Venus. Also, make it possible to use software rendering only while still having working cross-domain Wayland. Signed-off-by: Val Packett <[email protected]>
valpackett
force-pushed
the
val/myousnxpksmm
branch
from
2bfe82d to
f5a3df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vDRM is great, but not supported everywhere yet, so on some machines the only way to get GPU acceleration is via Venus. Also, make it possible to use software rendering only while still having working cross-domain Wayland.
Should we also automatically set
MESA_LOADER_DRIVER_OVERRIDE=zinkwhen Venus is selected?