-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge guest binaries. #134
base: main
Are you sure you want to change the base?
Merge guest binaries. #134
Conversation
FYI, I left a TODO in #130 about moving an env var to the muvm-guest config. If that gets merged first, please make that change too as part of the last commit here when you rebase. |
320d463
to
fd4381d
Compare
It is in the way for a refactor i want to do, and you should be using x11bridge anyway. Signed-off-by: Sasha Finkelstein <[email protected]>
9b974f5
to
f614c5f
Compare
Needs clippy fixes (probably just an |
We can keep the root uid in our saved set user id, and copy it to ruid/euid after fork, if launching as root is requested. Writing to drop_caches becomes a bit tricker when running unprivileged, but we can acquire the privileges in a forked process for it to work and not affect other launches. Signed-off-by: Sasha Finkelstein <[email protected]>
We no longer need the server to be a separate binary. Signed-off-by: Sasha Finkelstein <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
f614c5f
to
75aceea
Compare
Signed-off-by: Sasha Finkelstein <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
75aceea
to
c9a0c7a
Compare
Ah, thanks, it works headless again. It's also a bit faster now. Tried with #111, without these commits:
with:
By the way:
...not really substantial. Edit:
...neat, this. |
Whee, it comes with |
It being a tiny bit faster is expected (exec is not free), but is not the reason for those changes. |
Merge all guest binaries into one binary and process. This removes sommelier support, but people should use x11bridge anyway. Also stop leaking muvm configuration into vm processes.