Skip to content

Conversation

davide125
Copy link
Member

If we're not already inside a terminal, we need to run the package installation somewhere, otherwise it'll be completely invisible to the user.

@davide125 davide125 marked this pull request as draft March 14, 2025 03:46
@davide125
Copy link
Member Author

The current implementation is a hack that just spawns off a foot terminal window. Ideally we would use the default terminal emulator of the running DE, but somewhat surprisingly there doesn't seem to be a standardized way to find out what that is... (@Conan-Kudo any ideas here?)

Long term the right solution is sorting out #1 but that's going to take a while, and we need to get this fixed before f42 ships for the FEX change.

@Conan-Kudo
Copy link
Member

Short term, you're going to have to maintain a mapping of preferred terminals to desktops and have a fallback to foot.

Longer term, we could package up xdg-terminal-exec and get things updated so that the list is externalized and maintained properly as a global distro thing.

@davide125
Copy link
Member Author

xdg-terminal-exec seems to work as-is, at least in my limited testing. Maybe we can just use that even if it's still a proposed spec? I put it up for review in https://bugzilla.redhat.com/show_bug.cgi?id=2352603

@davide125 davide125 marked this pull request as ready for review March 14, 2025 22:52
@davide125
Copy link
Member Author

Switched to use xdg-terminal-exec. For now it'll fail silently if it's not installed. I plan to add some message boxes using rfd, but that needs to be packaged first, and it won't happen in time for Beta.

@davide125 davide125 merged commit b0937fe into AsahiLinux:main Mar 14, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants