Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the GitHub runner clock with the Windows time server #404

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

bjornoleh
Copy link
Contributor

Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

  • name: Sync clock
    run: sudo sntp -sS time.windows.com

Added to the following workflows / jobs:

  • validate_secrets.yml / validate-fastlane-secrets
  • add_identifiers.yml / identifiers
  • build_iAPS.yml / build
  • create_certs.yml / certificates

Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

- name: Sync clock
        run: sudo sntp -sS time.windows.com

Added to the following workflows / jobs:
- validate_secrets.yml / validate-fastlane-secrets
- add_identifiers.yml / identifiers
- build_iAPS.yml / build
- create_certs.yml / certificates
@bjornoleh
Copy link
Contributor Author

bjornoleh commented Dec 1, 2023

All four workflows have been tested successfully. No relevant errors were encountered.

The Sync clock step runs this command:

run: sudo sntp -sS time.windows.com

Observed time differences before syncing the clock:
Validate Secrets: +0.369539 +/- 0.060284
Add Identifiers: -4.125202 +/- 0.041137
Create Certificates: +0.236225 +/- 0.054157
Build iAPS: +0.128533 +/- 0.065851

Some more runs

-215.021491
+0.083260
+ 0.104221
+ 0.101976
+ 0.158417

@bjornoleh
Copy link
Contributor Author

bjornoleh commented Dec 1, 2023

@Jon-b-m , this PR is ready to be merged. You may also want to get this into #400, so that users of main can get rid of all the build errors.

If the root cause in the github runners (macos-13) gets fixed, we can opt to revert this workaround. But it does no harm.

@dnzxy
Copy link
Contributor

dnzxy commented Dec 1, 2023

@Jon-b-m , this PR is ready to be merged. You may also want to get this into #400, so that users of main can get rid of all the build errors.

Please watch out not to immediately port auto builds with this fix if we do not want to push auto build to main yet.

@Jon-b-m
Copy link
Member

Jon-b-m commented Dec 2, 2023

@Jon-b-m , this PR is ready to be merged. You may also want to get this into #400, so that users of main can get rid of all the build errors.

If the root cause in the github runners (macos-13) gets fixed, we can opt to revert this workaround. But it does no harm.

It would be better if you PR:ed this particular fix to the 2.3.0 PR, if needed, thanks.

@Jon-b-m Jon-b-m merged commit cb67cbe into Artificial-Pancreas:dev Dec 2, 2023
@bjornoleh
Copy link
Contributor Author

@Jon-b-m , this PR is ready to be merged. You may also want to get this into #400, so that users of main can get rid of all the build errors.
If the root cause in the github runners (macos-13) gets fixed, we can opt to revert this workaround. But it does no harm.

It would be better if you PR:ed this particular fix to the 2.3.0 PR, if needed, thanks.

Thanks, I have opened #406 to get this into 2.3.0.

@bjornoleh bjornoleh deleted the sync_clock branch December 2, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants