AP_DDS: Add topic retries #31599
Open
AP_DDS: Add topic retries #31599
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephendade
force-pushed
the
dds-reliability-fixes
branch
from
1a0b032 to
640d87e
Compare
Contributor
Author
It may help with the SITL CI issue. I was definitely seeing that issue on real HW (DDS via PPP UDP) when I restarted the agent (causing a re-connection in AP_DDS). I'd assumed is was due to lost packets. However, given @Ryanf55's comments iun the linked issue, it may be a deeper issue that affects both SITL and real HW. Not sure how'd we'd check if this improves the CI, given how flaky the test is? Other than running the test dozens of times and seeing what % of failures we get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds topic retries to AP_DDS. It a topic fails to initialise, AP_DDS will retry two more times before erroring out.
This adds more robustness to the DDS initialisation, if the network/serial link is a little lossy.
I also added an extra GCS_SEND_TEXT to let the user know if DDS is operating over a serial or UDP link, as it's not always obvious.
Tested on a Cube Orange with RasPi4