Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_NavEKF3: move definition of MAX_EKF_CORES #28963

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

peterbarker
Copy link
Contributor

if you're not including the AP_NavEKF3 header then you don't get this definition and then you won't be able to compile the DAL.

if you're not including the AP_NavEKF3 header then you don't get this definition and then you won't be able to compile the DAL.
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 30, 2024

How did you produce the error?
On master, this compiles:
./waf configure --board sitl --disable-EKF3 && nice ./waf plane

@peterbarker
Copy link
Contributor Author

How did you produce the error? On master, this compiles: ./waf configure --board sitl --disable-EKF3 && nice ./waf plane

Moved the include of AP_NavEKF3/AP_NavEKF3.h to a different file in libraries/AP_AHRS and added conditional compilation guards around that new header file. See my pr/active-ekf-type branch if you're curious.

This can't be replicated in master ATM - but it is clearly a layering problem.

@tridge tridge merged commit a794688 into ArduPilot:master Dec 30, 2024
99 checks passed
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 31, 2024

How did you produce the error? On master, this compiles: ./waf configure --board sitl --disable-EKF3 && nice ./waf plane

Moved the include of AP_NavEKF3/AP_NavEKF3.h to a different file in libraries/AP_AHRS and added conditional compilation guards around that new header file. See my pr/active-ekf-type branch if you're curious.

This can't be replicated in master ATM - but it is clearly a layering problem.

Ah I see, thanks! Good change.

@peterbarker peterbarker deleted the pr/move-MAX_EKF_CORES branch December 31, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants