Skip to content

HUD/PrearmStatus: fix failure messages #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HUD/PrearmStatus: fix failure messages #3250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Controls/PrearmStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ public partial class PrearmStatus : Form
{
private static readonly ILog log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);

private DateTime lastRequestTime = DateTime.MinValue;
private DateTime searchTime = DateTime.MinValue;
private DateTime lastRequestTime = DateTime.MaxValue;
private DateTime searchTime = DateTime.MaxValue;
public PrearmStatus()
{
InitializeComponent();
Expand Down
21 changes: 14 additions & 7 deletions ExtLibs/ArduPilot/CurrentState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ public bool prearmstatus
get => connected && (sensors_health.prearm || !sensors_enabled.prearm);
}

private DateTime last_good_prearm = DateTime.MaxValue;

private bool useLocation;

/// <summary>
Expand Down Expand Up @@ -1228,10 +1230,10 @@ public string messageHigh
if (value == null || value == "")
return;
// check against get
_messageHighTime = DateTime.Now;
if (messageHigh == value)
return;
log.Info("messageHigh " + value);
_messageHighTime = DateTime.Now;
_messagehigh = value;
messageHighSeverity = MAVLink.MAV_SEVERITY.EMERGENCY;
}
Expand Down Expand Up @@ -2886,12 +2888,7 @@ private void Parent_OnPacketReceived(object sender, MAVLink.MAVLinkMessage mavLi
messageHigh = "InternalError 0x" + (errors_count1 + (errors_count2 << 16)).ToString("X");
}

if (!sensors_health.prearm && sensors_enabled.prearm && sensors_present.prearm)
{
messageHigh = messages.LastOrDefault(a => a.message.ToLower().Contains("prearm")).message
?.ToString();
}
else if (!sensors_health.gps && sensors_enabled.gps && sensors_present.gps)
if (!sensors_health.gps && sensors_enabled.gps && sensors_present.gps)
{
messageHigh = Strings.BadGPSHealth;
}
Expand Down Expand Up @@ -2967,6 +2964,16 @@ private void Parent_OnPacketReceived(object sender, MAVLink.MAVLinkMessage mavLi
{
messageHigh = Strings.BadAirspeed;
}
else if (!sensors_health.prearm && sensors_enabled.prearm && sensors_present.prearm)
{
messageHigh = messages.LastOrDefault(a =>
a.message.ToLower().Contains("prearm") &&
a.time > last_good_prearm).message?.ToString();
}
if (last_good_prearm > DateTime.Now || sensors_health.prearm || !sensors_enabled.prearm || !sensors_present.prearm)
{
last_good_prearm = DateTime.Now;
}
}

break;
Expand Down
Loading