Skip to content

Conversation

@ferprojo
Copy link

@ferprojo ferprojo commented Aug 7, 2025

Found that when I accidentally scrolled too much on the piano roll window, it triggered a floating point exception. I looked at how the Editor implemented set_samples_per_pixel, and did the same, just returning when spp < 1. I'm new to ardour development so I don't know if this is correct, but it fixed it for me.

@x42
Copy link
Member

x42 commented Sep 28, 2025

I'd assume the better solution would be if (spp < 1) { spp = 1; }
Then again ideally that case should not happen in the first place, and we just add an assert (spp > 0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants