Skip to content

Conversation

@paseri3739
Copy link

Added DISABLE_VISIBILITY to compile patched GTK+ on OSX correctly.

@x42
Copy link
Member

x42 commented Jul 24, 2024

Why is this patch needed? and why would you want to disable visibility? gdk/gtk internal functions should remain hidden, no?

@tkysfjk
Copy link

tkysfjk commented Dec 29, 2024

@paseri3739 @x42
Seems that this relates to error: aliases are not supported on darwin.
I found alternative solution which uses CFLAGS/CPPFLAGS with --keepflags waf option instead of modifying codes.

ex.

$ PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/opt/homebrew/opt/libarchive/lib/pkgconfig" \
    CPPFLAGS="-DDISABLE_VISIBILITY -I/opt/homebrew/include -I/opt/homebrew/Cellar/libarchive/3.7.7/include" \
    CFLAGS="-DDISABLE_VISIBILITY -I/opt/homebrew/include -I/opt/homebrew/Cellar/libarchive/3.7.7/include" \
    LDFLAGS="-L/opt/homebrew/lib -L/opt/homebrew/Cellar/libarchive/3.7.7/lib" \
    ./waf configure --keepflags

@pauldavisthefirst
Copy link
Contributor

I would still like some explanation on why you feel this change is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants