Skip to content

Conversation

@kindasneaki
Copy link
Collaborator

What is this fixing or adding?

  • Adding support for the new (year late) SOTS DLC expansion

    • New option to turn on SOTS DLC: dlc_sots
    • New Environments
      • Shattered Abodes
      • Reformed Altar
      • Treeborn Colony
      • Helminth Hatchery
      • Viscous Falls
      • Disturbed Impact
      • Golden Dieback
      • Prime Meridian
    • New Victory falseson
  • New option to allow stage variants: stage_variants

    • There were getting to be too many stage 1's when stage variants were included with all DLC's turned on, so this option is intended to smoothen out the game play for newer players with it being defaulted false.
  • New option for seer portals to show on teleporter: show_seer_portals (option for client feature)

Added new archipelago.json file for .apworld

How was this tested?

  • Multiple solo runs.
  • Posted .apworld in #risk-of-rain-2 for the community to use.
  • Unit tests for the new victory

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 19, 2025
@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 20, 2025
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few smaller nitpicks in the docs, otherwise the code looks good! Nice and clean addition. Did not test anything outside of a generation locally.

Off-topic: A bunch of files still use the old typing style (capital versions of types), and could be switched to the modern versions (reducing the number of imports needed). Completely uncessary for the PR but something that I did notice.

* `All the Hidden Realms`

Dlc_Sotv items
DLC Survivors of the void (SOTV) items
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DLC Survivors of the void (SOTV) items
DLC Survivors of the Void (SOTV) items

Comment on lines +99 to +103
* `Shattered Abodes`, `Vicious Falls`, `Disturbed Impact`
* `Reformed Altar`
* `Treeborn Colony`, `Golden Dieback`
* `Prime Meridian`
* `Helminth Hatchery`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what you're trying to do here, but I think it looks better as a list like for SOTV when it is rendered

Copy link
Contributor

@FlitPix FlitPix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've played and generated multiple seeds and haven't had any major issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants