-
Notifications
You must be signed in to change notification settings - Fork 1.2k
RoR2: Seekers of the Storm (SOTS) DLC Support #5569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RoR2: Seekers of the Storm (SOTS) DLC Support #5569
Conversation
nicholassaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few smaller nitpicks in the docs, otherwise the code looks good! Nice and clean addition. Did not test anything outside of a generation locally.
Off-topic: A bunch of files still use the old typing style (capital versions of types), and could be switched to the modern versions (reducing the number of imports needed). Completely uncessary for the PR but something that I did notice.
| * `All the Hidden Realms` | ||
|
|
||
| Dlc_Sotv items | ||
| DLC Survivors of the void (SOTV) items |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| DLC Survivors of the void (SOTV) items | |
| DLC Survivors of the Void (SOTV) items |
| * `Shattered Abodes`, `Vicious Falls`, `Disturbed Impact` | ||
| * `Reformed Altar` | ||
| * `Treeborn Colony`, `Golden Dieback` | ||
| * `Prime Meridian` | ||
| * `Helminth Hatchery` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand what you're trying to do here, but I think it looks better as a list like for SOTV when it is rendered
FlitPix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've played and generated multiple seeds and haven't had any major issues.
What is this fixing or adding?
Adding support for the new (year late) SOTS DLC expansion
dlc_sotsfalsesonNew option to allow stage variants:
stage_variantsfalse.New option for seer portals to show on teleporter:
show_seer_portals(option for client feature)Added new
archipelago.jsonfile for .apworldHow was this tested?