Like Everything: Add spaces in concatenated strings #5564
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
duckboycool
commented
Oct 17, 2025
| "Those cows are weird.", | ||
| 0x07: "Preserved with special\n" | ||
| " wall-based methods.", | ||
| "wall-based methods.", |
There was a problem hiding this comment.
This and the other one in this file are the ones I mentioned being unsure.
This was referenced Oct 17, 2025
|
The changes to Factorio and LttP look fine to me. |
silasary
approved these changes
Oct 18, 2025
NewSoupVi
added
the
waiting-on: world-maintainer
|
This kind of thing should really be one PR per world or world maintainer, even if it's a lot of tiny changes. It's annoying I know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I noticed that in the messages added in #5478, there were spaces mistakenly missing between the parts of the string that were on different lines, so I tried to check if there were other instances. There were.
How was this tested?
I tried to get a couple of these to print in order to test them, but most of them aren't. I'm pretty sure all of these are unintentional, (aside from maybe the couple of removed ones in CV64).
If this makes graphical changes, please attach screenshots.
🚀🧑🚀