Timespinner: Correct torch locations logic #5561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now match upstream Timespinner Randomizer logic
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: bug/fix
|
#5562 |
|
I'm fine closing mine and going with TriumphantBass's, though I did notice a couple issues in theirs that I'll point out. |
github-actions
bot
removed
waiting-on: world-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
This corrects logic for several torch locations. Previous logic could have generated impossible seeds depending on item placement.
How was this tested?
Generated multiple seeds and verified logic matched expected outcomes, including some test outputs where items were included in the logical playthrough only for newly changed locations containing required items, and where seeds that created previously impossible layouts now generate different, completeable layouts.
If this makes graphical changes, please attach screenshots.
(N/A)