Skip to content

Edited credits for sc2 worlds #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1,522 commits into
base: main
Choose a base branch
from
Open

Edited credits for sc2 worlds #5549

wants to merge 1,522 commits into from
+1 −0

Conversation

Subsourian
Copy link

Added Mindhawk to contributors.md for the sc2 world to add his voicework for the custom units

Ziktofel and others added 30 commits April 20, 2025 01:07
@Ziktofel
Add unit test for locked unreleased items
83e06d3
@Ziktofel
Improve backwards compatibility
931751b
@Ziktofel
Fix flaky test
5a478c8
@Ziktofel
Fix WoL buildings group
1bc77bf
@Ziktofel
Adjust some item groups
47d5089
@Ziktofel
Use pre_fill for Kerrigan levels too
1416c11
@Ziktofel
Fix flaky test
b125f14
@Ziktofel
Exclude Merc-only upgrades if no mercs are present
379f776
@Ziktofel
Update End Game logic
459c53a
@Ziktofel
Don't generate Kerrigan items if only Amon's Fall is the only mision …
2389b08 
…featuring her
@Ziktofel
Fix some item parent/description
74f89b8
@Ziktofel
Minor logic fix
5ba2718
@Ziktofel
Attempt to fix stuck tooltip
9961227
@Ziktofel
Attempt to fix hanging tooltips
9317081
@Ziktofel
Do more aggressive tooltip removal to drop hanging tooltips
9745957
@Salzkorn
Make Hopscotch spacer configurable
e24c563
@Ziktofel
Merge pull request Ziktofel#458 from Salzkorn/sc2-next
695a5bb 
Make Hopscotch spacer configurable
@Ziktofel
Update Engine of Destruction logic
f1d9af0
@Ziktofel
Merge branch 'sc2-next' of github.com:Ziktofel/Archipelago into sc2-next
eda0227
@Ziktofel
Minor cleanup
6b77f89
@Ziktofel
Grammar update
b723509
@Ziktofel
Allow Adepts as Zealot variant in The Spear of Adun
7e0c95a
@Ziktofel
Add key item group
09d4127
@SirChuckOfTheChuckles
Location name fixes
82db8f6
@Ziktofel
Merge pull request Ziktofel#459 from SirChuckOfTheChuckles/Instigatin…
c45d44e 
…gInstigators

Location name fixes
@Salzkorn
Attempt to improve Void Trade stability
8b75104
@Ziktofel
Merge pull request Ziktofel#460 from Salzkorn/sc2-next
c9a9a1d 
Attempt to improve Void Trade stability
@Salzkorn
Fix starting missions not respecting Item rules
61a7bea
@Ziktofel
Fix a bug in backwards compatibility
a00e908
@Ziktofel
Merge pull request Ziktofel#462 from Salzkorn/sc2-next
215c386 
Fix starting missions not respecting Item rules
MatthewMarinets and others added 23 commits August 13, 2025 10:51
@MatthewMarinets
sc2: Adding a back in the saddle hard rule for getting past the ultra
af616ae
@MatthewMarinets
sc2: Further BitS feedback; ults included, fortitude/mend excluded
c30763c
@MatthewMarinets
sc2: Updating BitS with test feedback from Snarky
aa3e569
@MatthewMarinets
sc2: BitS rule -- don't check for kerriganless, just force the items in
10bd0eb
@MatthewMarinets
sc2: BitS allowing heroic fortitude-only with some levels; adding a c…
81e1d78 
…omment about kerrigan presence check
@MatthewMarinets
sc2: Adding mend as a substitute for Fortitude on BitS
7c77327
@MatthewMarinets
sc2: BitS no longer requires levels for mend
6c23fdf
@MatthewMarinets
sc2: giving BitS infest broodlings a 5 level safety margin
e987170
@Ziktofel
Merge pull request Ziktofel#510 from MatthewMarinets/mm/back_in_the_s…
cc389bc 
…addle_logic

sc2: Adding a back in the saddle hard rule for getting past the ultra
@Ziktofel
SC2Client: Use the extended item information only if the target game …
ef9963d 
…is SC2
@Ziktofel
Merge branch 'main' of github.com:ArchipelagoMW/Archipelago into sc2-…
f3ed360 
…next
@Ziktofel
Bump required client version
52ac3ec
@Salzkorn
Force-close SC2 on client close during load screen
d0dcc11
@Ziktofel
Merge pull request Ziktofel#513 from Salzkorn/sc2-next
e90e8c6 
Force-close SC2 on client close during load screen
@Ziktofel
Use OptionError for bad option combinations. See ArchipelagoMW#5370
6fd6076
@Ziktofel
Fix a case with enabled races option being an empty list
44e43fa
@Ziktofel
Use two starting slots for layouts only if the layout is at least siz…
bae25c5 
…e 2. See ArchipelagoMW#5368
@Ziktofel
Raise a meaninful error if all potetial missions are excluded. See Ar…
8350659 
…chipelagoMW#5368
@Ziktofel
Unit test fix
c3c1652
@MatthewMarinets
sc2: Fixing an issue where HotS wasn't a goal campaign on vanilla wit…
9ecc10b 
…h epilogue excluded
@Ziktofel
Merge pull request Ziktofel#514 from MatthewMarinets/mm/hots_not_goal…
05a2c13 
…_on_vanilla

sc2: Fixing an issue where HotS wasn't a goal campaign on vanilla with epilogue excluded
@Ziktofel
Merge remote-tracking branch 'origin/main' into sc2-next
915f3b8
@Subsourian
Added Mindhawk Credit for the Caladrius voice
d739a2e
@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 15, 2025
nicholassaylor
nicholassaylor approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good for them!

@Ziktofel
Copy link
Collaborator

If possible, try to make it only one commit, but it's a one-line change (the problem is that the underlying base got squashed instead but the problem will be gone with squashing this PR too)

@Ziktofel Ziktofel added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Ziktofel Ziktofel Ziktofel approved these changes

@nicholassaylor nicholassaylor nicholassaylor approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Subsourian @Ziktofel @nicholassaylor @Salzkorn @SirChuckOfTheChuckles @Magnemania @AYaroslavskiy91 @MatthewMarinets @octylFractal @EnvyDragon