Skip to content

Conversation

@palex00
Copy link
Contributor

@palex00 palex00 commented Oct 14, 2025

What is this fixing or adding?

It changes the default for the "force:"-option in plando from silent to true.

https://discord.com/channels/731205301247803413/1425078461298638878
This was suggested here and highly upvoted.

How was this tested?

I generated this YAML and it failed:

game: ChecksFinder
ChecksFinder:
  plando_items:
    - items:
        Map Bombs: 1
      locations:
        - "Route 1 - Free Sample Man"

I generated this yaml also on 0.6.3 and it succeeded. The difference is that behind the scene the force-default was changed.

Thanks to Silvris for pointing me in the right direction.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 14, 2025
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the Discord thread and walked through the Git history, everything LGTM.

This would definitely be better for custom games troubleshooting, but I also see the side where false could be a default. Overall I believe that true is the better option of the 3.

@NewSoupVi
Copy link
Member

I think False is the best default. I agree "silent" is a bad default. Curious to hear what other core maintainers think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants