-
Notifications
You must be signed in to change notification settings - Fork 1
Tools filter #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools filter #3
Conversation
EricGustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spartee the get_arcade_tools does not behave the way that I would expect (irrespective of this current PR).
tools = await get_arcade_tools(
client,
toolkits=["github"],
tools=["Google.ListEmails"]
)
# Expected: All github tools + list emails tool
# Actual: All github tools (list emails tool is missing)Seems to me that we are missing a call to client.tools.formatted.get. i.e.,
for tool in tools:
tool_format = await client.tools.formatted.get(
name=tool,
format="openai"
)
tool_formats.append(tool_format)This is how langchain-arcade and crewai-arcade behave at least.
|
@EricGustin Hmm... from the code here I thought the second parameter was a "filter" for the toolkit. I will implement the same behavior as in the other packages for consistency. It's a better DX that way. Making this a draft until I push that! |
|
@sdserranog I think we should update the docs to follow changes in this PR, as the API will be consistent with how langchain-arcade and crewai-arcade behave. I don't know which order is best to approve these PRs though. |
|
@sdserranog On this commit I addressed all of the comments from the other PR. |
sdserranog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and approve this since the core functionality is working well. We'll still need to clean up/fix the documentation, but we can handle that in a follow-up PR


This adds a docstring to
get_arcade_toolsthat documents and implements thetoolsparameter so not everything in a toolkit is included.