[TOO-1171] feat(arcade-core): add Sentry OAuth2 provider class#874
Draft
EricGustin wants to merge 1 commit into
Draft
[TOO-1171] feat(arcade-core): add Sentry OAuth2 provider class#874EricGustin wants to merge 1 commit into
EricGustin wants to merge 1 commit into
Conversation
Adds `class Sentry(OAuth2)` (provider_id "sentry") so toolkit authors can declare `requires_auth=Sentry()`, mirroring the existing well-known provider classes, and re-exports it from the arcade-tdk and arcade-mcp-server auth modules. Sister to the Engine well-known provider (TOO-1170). Adds the dynamic test_auth_providers.py, which constructs every OAuth2 subclass so a newly added provider is covered with no per-provider edit; arcade_core/auth.py reports 100% coverage with Sentry included. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Sentry OAuth2 provider class
Adds
class Sentry(OAuth2)(provider_id = "sentry") so toolkit authors can declarerequires_auth=Sentry(), mirroring the existing well-known provider classes, and re-exports it fromarcade_tdk.authandarcade_mcp_server.auth.Sister to the Engine well-known provider (monorepo, TOO-1170) and the docs page (TOO-1175).
Patch coverage proof
The new class adds a
super().__init__line that only runs on instantiation.libs/tests/core/test_auth_providers.py(added here) parametrizes over everyOAuth2subclass inarcade_core.authand constructs each, so a newly added provider is covered with no per-provider edit:ruff checkon the changed files: clean.Closes TOO-1171
🤖 Generated with Claude Code