Conversation
| /// execution on one shard. If set incorrectly (i.e., a wrong shard key value), the query may | ||
| /// be shipped to the wrong DBServer and return no results (empty result set). Use at your own risk. | ||
| /// </summary> | ||
| public string ForceOneShardAttributeValue { get; set; } |
There was a problem hiding this comment.
The option doesn't appear in any documentation for the cursor API that I can find, are you able to find a reference for it?
As mentioned in the other PR, I wonder if you could subclass PostCursorOptions and add additional properties? I think JSON.NET serializer will include the additional properties on your subclass
There was a problem hiding this comment.
The option does not appear in ArangoDB's official REST API specification; however, as I mentioned above, it does appear in the Java and Golang driver docs. I can also link you to relevant ArangoDB developers who will confirm that.
As I mentioned in the other PR, the subclass approach works, so I can achieve what I've needed regarding that option regardless of that PR.
However, I think it's worth adding that option to the cursor option since it's a known ArangoDB option.
There was a problem hiding this comment.
Thanks @RonAmihai. It's not the first time we see undocumented options. Can you confirm the ArangoDB version this was introduced in?
Maybe report this missing option on Slack or on the docs project.
There was a problem hiding this comment.
There was a problem hiding this comment.
forceOneShardAttributeValue appears in the changelog under v3.9.0-alpha.1 (2021-11-30): https://github.com/arangodb/arangodb/blob/v3.12.10/CHANGELOG#L8029
It was added in arangodb/arangodb#14701
|
Hi @RonAmihai, I'm waking up from a deep slumber 😄 Are you up for updating this PR? It has caught a conflict after merging #517 |
Never mind, it was an easy one to resolve, I've done it while merging master into this branch. 👌 |
DiscoPYF
left a comment
DiscoPYF
left a comment
There was a problem hiding this comment.
Thanks @RonAmihai for this contribution!
Would be nice to mention that this is available from 3.9.0 onwards. But the description is consistent with the java driver and 3.9.0 was a long time ago, so not a big deal.
📝 For future reference:
forceOneShardAttributeValueappears in the changelog underv3.9.0-alpha.1 (2021-11-30): https://github.com/arangodb/arangodb/blob/v3.12.10/CHANGELOG#L8029- It was added in arangodb/arangodb#14701
| /// execution on one shard. If set incorrectly (i.e., a wrong shard key value), the query may | ||
| /// be shipped to the wrong DBServer and return no results (empty result set). Use at your own risk. | ||
| /// </summary> | ||
| public string ForceOneShardAttributeValue { get; set; } |
There was a problem hiding this comment.
forceOneShardAttributeValue appears in the changelog under v3.9.0-alpha.1 (2021-11-30): https://github.com/arangodb/arangodb/blob/v3.12.10/CHANGELOG#L8029
It was added in arangodb/arangodb#14701
3 participants
See: