feat(flutter): pre-defined response formats #7128

richardshiue · 2025-01-02T12:02:05Z

Desktop:

input:

regenerate:

Mobile:

input:

regenerate:

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

github-actions · 2025-01-02T12:02:48Z

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project `/project.inlang`

lint rule	new reports	level	link
Missing translation	420	warning	contribute (via Fink 🐦)

codecov · 2025-01-02T12:09:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.62%. Comparing base (5121138) to head (6361147).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7128      +/-   ##
==========================================
- Coverage   57.69%   57.62%   -0.08%     
==========================================
  Files         320      320              
  Lines       14057    14057              
  Branches     2039     2039              
==========================================
- Hits         8110     8100      -10     
- Misses       5683     5694      +11     
+ Partials      264      263       -1

Flag	Coverage Δ
appflowy_web_app	`57.62% <ø> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xazin

👍

Xazin · 2025-01-04T22:48:50Z

frontend/appflowy_flutter/lib/plugins/ai_chat/application/chat_entity.dart

+        TextFormat.bulletList => ResponseTextFormatPB.BulletedList,
+        TextFormat.numberedList => ResponseTextFormatPB.NumberedList,
+        TextFormat.table => ResponseTextFormatPB.Table,
+        null => null


I understand the sentiment, but might as well be a default case no? _ => null

I guess it's not important, this way you get a warning I suppose when you add a new TextFormat.

Xazin · 2025-01-04T22:50:27Z

...nd/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart

+                                setState(() {
+                                  predefinedFormat = format;
+                                });


\nit

Suggested change

setState(() {

predefinedFormat = format;

});

setState(() => predefinedFormat = format);

Xazin · 2025-01-04T22:52:08Z

...nd/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart

+    if (showPredefinedFormatSection) {
+      widget.onSubmitted(trimmedText, predefinedFormat, metadata);
+    } else {
+      widget.onSubmitted(trimmedText, null, metadata);
+    }


Suggested change

if (showPredefinedFormatSection) {

widget.onSubmitted(trimmedText, predefinedFormat, metadata);

} else {

widget.onSubmitted(trimmedText, null, metadata);

}

widget.onSubmitted(trimmedText, showPredefinedFormatSection ? predefinedFormat : null, metadata);

Xazin · 2025-01-04T22:52:21Z

...nd/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart

    this.hintText = "",
+    // this.onStartMentioningPage,


Xazin · 2025-01-04T22:52:28Z

...nd/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart

  final String hintText;
+  // final void Function()? onStartMentioningPage;


Xazin · 2025-01-04T22:53:30Z

...end/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/mobile_ai_prompt_input.dart

+                          setState(() {
+                            predefinedFormat = format;
+                          });


\nit

Suggested change

setState(() {

predefinedFormat = format;

});

setState(() => predefinedFormat = format);

Xazin · 2025-01-04T22:53:55Z

...end/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/mobile_ai_prompt_input.dart

      child: _LeadingActions(
-        textController: textController,
        // onMention: () {


Can we remove if we don't need this?

Xazin · 2025-01-04T22:58:10Z

.../appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/predefined_format_buttons.dart

+              child: FlowySvg(
+                format.icon,
+                size: format == ImageFormat.textAndImage
+                    ? Size(21.0 / 16.0 * iconSize, iconSize)


This way of calculating the height seems scary haha.

Mobile: 26.25 if IconSize is 20
Desktop: 21 if IconSize is 16

Feels like black magic 😂

Xazin · 2025-01-04T22:59:38Z

...appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_change_format_bottom_sheet.dart

+      leftIcon: FlowySvg(
+        format.icon,
+        size: format == ImageFormat.textAndImage
+            ? const Size(21.0 / 16.0 * 20, 20)


Suggested change

? const Size(21.0 / 16.0 * 20, 20)

? const Size(26.25, 20)

This value is a bit odd, but there's no need to have a calculation here.

richardshiue added the v0.8.0 label Jan 2, 2025

richardshiue force-pushed the feat/pre-defined-formats branch from 4092970 to cb81747 Compare January 2, 2025 12:17

richardshiue changed the title ~~feat: pre-defined response formats~~ feat(flutter): pre-defined response formats Jan 3, 2025

richardshiue added 4 commits January 3, 2025 10:12

feat: pre-defined response formats

bb4b6b7

chore: adjust bottom sheet

df05e3b

chore: rename and clean up enums

31a756b

chore: move all mobile input actions to the bottom

c9bca30

richardshiue force-pushed the feat/pre-defined-formats branch from 5b75bdb to c9bca30 Compare January 3, 2025 02:12

richardshiue added 2 commits January 3, 2025 16:54

chore: bump client-api

6671422

chore: connect to API

dc0e491

richardshiue force-pushed the feat/pre-defined-formats branch from 7e4baa7 to dc0e491 Compare January 3, 2025 10:31

Xazin approved these changes Jan 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(flutter): pre-defined response formats #7128

feat(flutter): pre-defined response formats #7128

richardshiue commented Jan 2, 2025

github-actions bot commented Jan 2, 2025 •

edited

Loading

codecov bot commented Jan 2, 2025 •

edited

Loading

Xazin left a comment

Xazin Jan 4, 2025 •

edited

Loading

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

Xazin Jan 4, 2025

		final String hintText;
		// final void Function()? onStartMentioningPage;

feat(flutter): pre-defined response formats #7128

Are you sure you want to change the base?

feat(flutter): pre-defined response formats #7128

Conversation

richardshiue commented Jan 2, 2025

Feature Preview

PR Checklist

github-actions bot commented Jan 2, 2025 • edited Loading

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

codecov bot commented Jan 2, 2025 • edited Loading

Codecov Report

Xazin left a comment

Choose a reason for hiding this comment

Xazin Jan 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 2, 2025 •

edited

Loading

Project `/project.inlang`

codecov bot commented Jan 2, 2025 •

edited

Loading

Xazin Jan 4, 2025 •

edited

Loading