Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon picker issues on mobile #7114

Open
wants to merge 2 commits into
base: release/0.7.9
Choose a base branch
from

Conversation

asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented Dec 31, 2024

Fix issue #7101

  • fix: error displaying in Page style
  • fix: complete the filter logic of icon picker
  • fix: error displaying in Favorite/Recent page
  • fix: the color picker showed when tapping down
  • fix: icons are not supported in subpage blocks

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@asjqkkkk asjqkkkk requested a review from LucasXu0 December 31, 2024 06:39
@Xazin
Copy link
Contributor

Xazin commented Jan 1, 2025

It seems this PR is behind #7113 but is the same, is this PR a mistake?

@asjqkkkk
Copy link
Collaborator Author

asjqkkkk commented Jan 2, 2025

It seems this PR is behind #7113 but is the same, is this PR a mistake?

They are used for submitting to different branches. One is release/0.7.9, another is main

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jan 3, 2025

Rebase or merge the latest main branch

@asjqkkkk asjqkkkk force-pushed the hotfix/0.7.9 branch 2 times, most recently from 1f82c66 to b8e3a3f Compare January 3, 2025 02:37
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jan 3, 2025

The changes in this commit should not be included in this PR.

Screenshot 2025-01-03 at 15 43 07

* fix: error displaying in Page style

* fix: error displaying in Favorite/Recent page

* fix: complete the filter logic of icon picker

* fix: the color picker showed when tapping down

* fix: icons are not supported in subpage blocks

* chore: add some tests

* fix: recent icons not working for grid header icon
@asjqkkkk asjqkkkk force-pushed the hotfix/0.7.9 branch 2 times, most recently from c0dbe40 to 83259bc Compare January 4, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants