fix: updated link preview node attributes#15
Open
Omegaviv wants to merge 3 commits intoAppFlowy-IO:mainfrom
Open
fix: updated link preview node attributes#15Omegaviv wants to merge 3 commits intoAppFlowy-IO:mainfrom
Omegaviv wants to merge 3 commits intoAppFlowy-IO:mainfrom
Conversation
Xazin
approved these changes
May 28, 2024
Contributor
|
Looks good, we should add an option in AppFlowy itself to handle updating the meta information if there is a chance it's outdated. Eg. with GitHub previews and so forth. |
Contributor
|
Analyzer found an issue |
Author
last time you mentioned to add a reload option to refetch the metadata if user thinks it's outdated, so I think that will do the job. |
Xazin
reviewed
Jun 28, 2024
Comment on lines
148
to
+152
| future = parser.start(); | ||
|
|
||
| future.then( | ||
| (_) => WidgetsBinding.instance.addPostFrameCallback((_) => _updateNode()), | ||
| ); |
Contributor
There was a problem hiding this comment.
One minor thing, we shouldn't even need to call the parser if the attributes exist.
I will amend with a new commit.
The idea is to avoid a new request if the node already contains the information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part fix for #13
Updated linkPreview node with attributes (title, description) after it is fetched. This will be used for Issue #5193 fixing export markdown format.
PR Checklist