Fix/OIDC issues#116
Merged
Merged
Conversation
Accept null email in UserSyncRequest and derive it from the validated ID token, so providers that omit the email claim get a clear 400 instead of a Pydantic 422. Add OIDC_CA_BUNDLE setting so the backend can trust internal CAs without disabling TLS verification.
Authelia (and other providers) include email only in the userinfo endpoint, not the ID token. Profile callback now falls back to the userinfo endpoint using the access token when email is missing.
Adds docker-compose.oidc-test.yml and testing/authelia/ fixtures to spin up a real Authelia instance for validating the null-email and CA bundle fixes end-to-end. Includes a local CA, server cert, test users (alice: no email, bob: with email), and Authelia config.
@types/node@24 requires TypeScript 5.8+ and pulls in web-globals (fetch, streams, events) that duplicate DOM lib declarations. The frontend uses TypeScript 5.3.3, which is incompatible.
Lost when lockfile was regenerated. npm 10 (Node 20 CI) requires these optional entries to be present or it fails npm ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
Testing
Test Environment
Tests Performed
Screenshots (if applicable)
Additional Notes