Add null check when displaying project icons for MapContentView.#12239
Closed
m1cxzfw3q wants to merge 8 commits into
Closed
Add null check when displaying project icons for MapContentView.#12239m1cxzfw3q wants to merge 8 commits into
m1cxzfw3q wants to merge 8 commits into
Conversation
m1cxzfw3q
marked this pull request as ready for review
June 18, 2026 17:51
Owner
|
uiIcon should never be allowed to be null, and never appears as null in my tests. A null icon would crash other parts of the game. Can you provide steps to reproduce this in-game? |
Contributor
Author
|
Create buildings with errors in the game by data patches. Even with fullIcon and uiIcon configured, it will crash. |
Owner
|
The root cause has been fixed, but I added an extra check just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game crashes because the new project icon is empty.
So, this PR solves this issue by adding empty check for the image display part.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: