faster core proximity updates#12184
Open
WMF-Industries wants to merge 4 commits into
Open
Conversation
Abdullah-Ajeebi
approved these changes
Jun 5, 2026
Abdullah-Ajeebi
left a comment
Abdullah-Ajeebi
left a comment
There was a problem hiding this comment.
I tested the following changes and the lag is little to none.
Contributor
Author
|
found a few more edge cases that i have to fix before this can be merged |
Contributor
Author
|
i did quite a bit more testing, seems to be working correctly with only a minor bug in the in-game editor, if you enter it for the first time, everything's fine, but if you quit and re-enter, the item capacity for every team is 0 (editor only) |
Contributor
Author
|
okay, should be all good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need to iterate all of the team's cores upon one updating its proximity
Should work just fine, I've tested all the cases that came to my mind (adding storage, removing storage, cores and storage dying, changing teams, etc)
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: