refactor(thermal, renewable): create user classes #79
+694
−543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
changed the title
sylvlecl
approved these changes
Feb 12, 2025
| prepro: Optional[pd.DataFrame] = None, | ||
| modulation: Optional[pd.DataFrame] = None, | ||
| series: Optional[pd.DataFrame] = None, | ||
| CO2Cost: Optional[pd.DataFrame] = None, | ||
| fuelCost: Optional[pd.DataFrame] = None, | ||
| co2_cost: Optional[pd.DataFrame] = None, |
| from pydantic.alias_generators import to_camel | ||
|
|
||
|
|
||
| class APIBaseModel(BaseModel): |
There was a problem hiding this comment.
Nice, maybe we could move it to a base_model.py module for more visibility
There was a problem hiding this comment.
Yes why not it's a bit hidden inside the init file
There was a problem hiding this comment.
I'll do it inside another PR :)
| return RenewableClusterPropertiesAPI.model_validate(user_dict) | ||
|
|
||
| def to_user_model(self) -> RenewableClusterProperties: | ||
| return RenewableClusterProperties( |
There was a problem hiding this comment.
It looks kind of dirty that it passes the type checking since strictly speaking the properties are optional now.
But we can dismiss that issue.
There was a problem hiding this comment.
Indeed. We have the same issue concerning the settings. What should we do ? Introduce the same object with the default fields ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.