Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(settings): refactor settings to create an user oriented class #73

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Jan 30, 2025

What's done this PR achieves:

  • Introduces a dataclass StudySettings for the user
  • Use this class inside the Study object (before it was the union of 2 types local and API)
  • Implement the method update_settings for local
  • Uses the new endpoint of AntaresWeb (not merged yet 😄 ) so the code won't work until next web release (it's already the case due to the read_links method)
  • Removes test for playlist and thematic trimming (inside local) as they didn't handle real cases with multiple keys

What should be done next:

  • Introduce multiple keys ini reader/writer for thematic trimming and playlist (for local)
  • Handle playlist and thematic trimming reading and writing (for local)
  • Add tests (for local)

NB: I forgot what we said Sylvain about the splitting of the files study_settings_api and local between models and methods

@MartinBelthle MartinBelthle changed the title chore(settings): refactor settings to create an user oriented class refactor(settings): refactor settings to create an user oriented class Jan 31, 2025
@MartinBelthle MartinBelthle self-assigned this Feb 4, 2025
@MartinBelthle MartinBelthle marked this pull request as ready for review February 4, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant