Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload assets #746

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix upload assets #746

merged 2 commits into from
Jan 12, 2024

Conversation

JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented Jan 11, 2024 •
edited
Loading

  • Fix windows and centos workflow with missing variable interpolation to resolve artifact name
  • Fix ubuntu workflow where the same asset was uploaded twice

Tested through https://github.com/AntaresSimulatorTeam/antares-xpansion/releases/tag/v1.1.2

@JasonMarechal25 JasonMarechal25 force-pushed the feature/fix_upload_assets branch from 4783195 to a94876b Compare January 12, 2024 08:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JasonMarechal25 JasonMarechal25 merged commit b39ed45 into develop Jan 12, 2024
11 of 13 checks passed
@JasonMarechal25 JasonMarechal25 deleted the feature/fix_upload_assets branch January 12, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbittar tbittar tbittar approved these changes

@a-zakir a-zakir Awaiting requested review from a-zakir

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonMarechal25 @tbittar