Simplify API of Problem generation #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonMarechal25
force-pushed
the
feature/api_pbgen
branch
4 times, most recently
from
a880f81 to
1f90a80
Compare
JasonMarechal25
force-pushed
the
feature/api_pbgen
branch
from
bf8bcb2 to
db24f8b
Compare
Avoid race condition
JasonMarechal25
force-pushed
the
feature/api_pbgen
branch
from
b86869d to
e0422e3
Compare
a-zakir
approved these changes
Jan 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how -o and -a options work.
-a options doesn't need -o option anymore. Given the options -a simulation.zip it is now automatically deduced and output dir simulation-Xpansion.zip
-o options works by reading a directory (by opposition to reading an archive)
Move some code in RunProblemGeneration to classes