Feature/ant 2636 arrow #25
Conversation
| import java.util.function.Function; | ||
|
|
||
| public class ArrowReader { | ||
| private static final BufferAllocator ALLOCATOR = new RootAllocator(); |
There was a problem hiding this comment.
It has to be closed or created with try-with-ressources as per https://arrow.apache.org/docs/java/memory.html#bufferallocator.. to avoid memory leaks
| var vector = root.getVector(field.getName()); | ||
| var values = new double[vector.getValueCount()]; | ||
| for (var i = 0; i < vector.getValueCount(); i++) { | ||
| values[i] = ((Float8Vector) vector).get(i); |
There was a problem hiding this comment.
maybe is better to use instanceof instead of class casting..
| var rowCount = lines.size(); | ||
| var columnCount = lines.getFirst().split("\\s+").length; | ||
|
|
||
| return readMatrix(lines, rowCount, columnCount, Double::parseDouble, (data, value) -> data.add(Double.parseDouble(value))); |
There was a problem hiding this comment.
we need to handle case when line has less columns or more columns that the column count and skip them
|
|
||
| return new Matrix(columns); | ||
| } | ||
| } |
There was a problem hiding this comment.
may a 2-D array might be enough as we are dealing with primitives, take a look at this Java Arrays vs ArrayLists Guide | Medium
| IntStream.range(0, size).forEach(i -> vector.set(i, values[i])); | ||
| } | ||
|
|
||
| public void write(Matrix matrix, OutputStream out) throws IOException { |
There was a problem hiding this comment.
We should check if matrix is not null before treatement
salemsd
force-pushed
the
feature/ANT_2636_arrow
branch
from
e01b7eb to
129d4b2
Compare
|
No description provided.