Refactoring : move exe finding from command building to main program #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rogram Note that executable finding is now out from the loop over studies. Inside the loop, this task was unnecessarily repeated. Now it's done once.
guilpier-code
commented
Apr 4, 2024
| @@ -26,9 +26,6 @@ def find_studies_in_batch_dir(batch_name): | |||
|
|
|||
| return studies | |||
|
|
|||
| def get_headers(df) -> set : | |||
There was a problem hiding this comment.
get_headers is unused. It is removed.
| @@ -14,33 +20,22 @@ def find_exe_path(path_to_search_exe_in, exe_identifier): | |||
| return path_item.resolve() | |||
| raise RuntimeError("Missing {searched_exe}") | |||
|
|
|||
| def make_command_to_run(path_where_to_find_exe, batch_name, study_path): | |||
| def make_command_to_run(exe_path, batch_name, study_path): | |||
There was a problem hiding this comment.
make_command_to_run function is now simplified.
Code about finding the executable path was moved elsewhere (into the main program)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring : we move the path search for binary program to execute into the main program.
It allows :