Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes on refactor modeler PR #2616 #2619

Closed
wants to merge 9 commits into from

Conversation

guilpier-code
Copy link
Contributor

Little changes on #2616

@guilpier-code guilpier-code changed the base branch from develop to feature/refacto_modeler February 5, 2025 14:46
@flomnes
Copy link
Member

flomnes commented Feb 6, 2025

Compile error with MSVC

2025-02-05T14:58:14.4133986Z D:\a\Antares_Simulator\Antares_Simulator\src\expressions\visitors\CompareVisitor.cpp(51,22): error C2280: 'bool Antares::Expressions::Nodes::PortFieldNode::operator ==(const Antares::Expressions::Nodes::PortFieldNode &) const': attempting to reference a deleted function [D:\a\Antares_Simulator\Antares_Simulator\_build\expressions\expressions.vcxproj]
2025-02-05T14:58:14.4146260Z D:\a\Antares_Simulator\Antares_Simulator\src\expressions\visitors\CompareVisitor.cpp(51,22): error C2280: 'bool Antares::Expressions::Nodes::PortFieldNode::operator ==(const Antares::Expressions::Nodes::PortFieldNode &) const': attempting to reference a deleted function [D:\a\Antares_Simulator\Antares_Simulator\_build\expressions\expressions.vcxproj]

On g++

2025-02-05T14:49:34.5477729Z /home/runner/work/Antares_Simulator/Antares_Simulator/src/expressions/visitors/CompareVisitor.cpp: In instantiation of ‘bool compareEqualOperator(const T*, const Antares::Expressions::Nodes::Node*) [with T = Antares::Expressions::Nodes::PortFieldNode]’:
2025-02-05T14:49:34.5480535Z /home/runner/work/Antares_Simulator/Antares_Simulator/src/expressions/visitors/CompareVisitor.cpp:134:44:   required from here
2025-02-05T14:49:34.5483766Z /home/runner/work/Antares_Simulator/Antares_Simulator/src/expressions/visitors/CompareVisitor.cpp:51:22: error: use of deleted function ‘constexpr bool Antares::Expressions::Nodes::PortFieldNode::operator==(const Antares::Expressions::Nodes::PortFieldNode&) const’
2025-02-05T14:49:34.5485797Z    51 |         return *node == *other_node;

Base automatically changed from feature/refacto_modeler to develop February 6, 2025 11:26
@guilpier-code guilpier-code marked this pull request as draft February 7, 2025 12:16
@guilpier-code guilpier-code marked this pull request as ready for review February 7, 2025 12:19
@guilpier-code
Copy link
Contributor Author

Resolving conflicts is not worth it for so small changes

@guilpier-code guilpier-code deleted the fix/review-refactor-modeler branch February 7, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants