Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive ElemAlreadyExists from std::runtime_error #2614

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Derive ElemAlreadyExists from std::runtime_error #2614

merged 1 commit into from
Jan 30, 2025

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Jan 30, 2025

std::exception's constructors don't accept std::strings, so it's a bit strange to override method what

https://en.cppreference.com/w/cpp/error/exception/exception

@a-zakir
Copy link
Contributor

a-zakir commented Jan 30, 2025

I am always against this practice!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@flomnes flomnes merged commit ed5e579 into develop Jan 30, 2025
10 checks passed
@flomnes flomnes deleted the fix/exception-runtime-error branch January 30, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-zakir a-zakir a-zakir approved these changes

Assignees
No one assigned
Labels
code quality size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flomnes @a-zakir