Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recently introduced build warnings #2602

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Remove recently introduced build warnings #2602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fff6cd
Remove recently introduced build warnings
flomnes Jan 28, 2025
bc11cb8
Use attribute
flomnes Jan 28, 2025
7bce061
Review
flomnes Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libs/antares/study/parts/thermal/constant_cost_provider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ ConstantCostProvider::ConstantCostProvider(const ThermalCluster& cluster):
{
}

double ConstantCostProvider::getOperatingCost(uint serieIndex, uint hourInTheYear) const
double ConstantCostProvider::getOperatingCost(uint /*serieIndex*/, uint hourInTheYear) const
flomnes marked this conversation as resolved.
Show resolved Hide resolved
{
const auto* modCost = cluster.modulation[thermalModulationCost];
return cluster.marginalCost * modCost[hourInTheYear];
}

double ConstantCostProvider::getMarginalCost(uint serieIndex, uint hourInTheYear) const
double ConstantCostProvider::getMarginalCost(uint /*serieIndex*/, uint hourInTheYear) const
{
const double mod = cluster.modulation[Data::thermalModulationCost][hourInTheYear];
return cluster.marginalCost * mod;
}

double ConstantCostProvider::getMarketBidCost(uint hourInTheYear, uint year) const
double ConstantCostProvider::getMarketBidCost(uint hourInTheYear, uint /*year*/) const
{
const double mod = cluster.modulation[thermalModulationMarketBid][hourInTheYear];
return cluster.marketBidCost * mod;
Expand Down
4 changes: 2 additions & 2 deletions src/solver/simulation/common-hydro-remix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ std::vector<double> extractLoadForCurrentWeek(const Data::Area& area,
const unsigned int firstHourOfWeek)
{
std::vector<double> load_to_return(HOURS_IN_WEEK, 0.);
for (int h = 0; h < HOURS_IN_WEEK; h++)
for (unsigned int h = 0; h < HOURS_IN_WEEK; h++)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (unsigned int h = 0; h < HOURS_IN_WEEK; h++)
for (unsigned int h = 0; h < HOURS_IN_WEEK; ++h)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

{
load_to_return[h] = area.load.series.getColumn(year)[h + firstHourOfWeek];
}
Expand All @@ -255,7 +255,7 @@ std::vector<double> extractHydroPmin(const Data::Area& area,
{
// area->hydro.series->mingen.timeSeries
std::vector<double> hydroPmin(HOURS_IN_WEEK, 0.);
for (int h = 0; h < HOURS_IN_WEEK; h++)
for (unsigned int h = 0; h < HOURS_IN_WEEK; h++)
flomnes marked this conversation as resolved.
Show resolved Hide resolved
{
hydroPmin[h] = area.hydro.series->mingen.getColumn(year)[h + firstHourOfWeek];
}
Expand Down
Loading