Equality visitor #2335
Closed
Equality visitor #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomnes
reviewed
Aug 19, 2024
src/solver/expressions/include/antares/solver/expressions/nodes/TwoNodesVisitor.h
Show resolved
Hide resolved
flomnes
reviewed
Aug 19, 2024
| return ret.value(); | ||
| } | ||
| } | ||
| logs.error() << "Antares::Solver::Nodes Visitor: unsupported Node!"; |
There was a problem hiding this comment.
If node1 and node2 are of different types, we will encounter this line. So I think we should handle errors better here.
Example
Literal lit1(2), lit2(2);
AddNode node1(&lit1, &lit2);
MultiplicationNode node2(&lit1, &lit2);
EqualityVisitor equal;
// Here, we go through l. 78 above, but the caller only gets a log error
// and an `R()`, not so easy to catch
equal.dispatch(&node1, &node2); There was a problem hiding this comment.
update: the code print warning message and returns false
| } | ||
| else | ||
| { | ||
| return {}; |
There was a problem hiding this comment.
the return type is handled in the dispatch method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft